[Bug 11609] SIN and COS do not support angles outside of -PI to PI.

[<bug...@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=11609


sr...@tu... changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #3 from sr...@tu...  2007-07-29 10:46 PST -------
(In reply to comment #2)
> I've got a proposed fix up but I doubt it's optimal - it looks as if the
> beginning of the COS/SIN generators (MUL/MOD/MUL) was an attempt to normalize
> the angles, and I can run the routines fine without those three instructions...
> I can't quite figure out what the MOD is doing since it's not used anywhere
> else in the driver and it's not part of the GL spec.

Yes, those 3 instructions are for range reduction. The header file says A0_MOD
is dst = src0 fmod 1.0, so looks like a float modulo 1.0 to me...
Not sure why the code wouldn't work correctly, seems ok at first look (not sure
if the MULs you can use instead of the MADs  with the MOD is actually faster,
but it saves some constants at least).
Actually, looks not ok at second look... Should be fixed in git. If not reopen.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.