From: Ian R. <id...@us...> - 2005-08-30 15:33:54
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Stone wrote: > On Mon, 2005-08-01 at 09:37 -0700, Ian Romanick wrote: > >>The only way this could happen is if *both* PTHREADS and XTHREADS are >>defined. I suspect the Xthreads.h problem was always there, but it was >>never hit because XTHREADS was never defined. Some how, somewhere, >>XTHREADS is getting set. I'll have to look into it, but I think this is >>a bug in whatever X.org header is defining XTHREADS for us. :( > > Yes, you're spot on about PTHREADS and XTHREADS both being defined. > XlibConf.h now defines XTHREADS if we're using it, the consensus being > that if you're using <X11/Xlibint.h>, you deserve everything you get. Which I consider to be a bug, but apparently I'm the only one. If I wanted XTHREADS support, I'd ask for it. > I think this already got fixed, so the constructs are more like: > #if defined(PTHREADS) > ... > #elif defined(XTHREADS) > ... > #elif defined(...) > ... > #endif I did a global s/XTHREADS/USE_XTHREADS/ in Mesa. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFDFHvUX1gOwKyEAw8RAuVaAJ9iiEwNWlxb36hEkppEZdbzQPnfmACfb11B fOFf7DBnT8Z06+AS6IpWw5E= =uqHq -----END PGP SIGNATURE----- |