Re: [Unichrome-users] Re: [PATCH drm] sis and via security check for memory alloc.

[<uni...@sh...>]

Micha=C5=82 Pytasz wrote:

>On Thursday 11 of August 2005 14:21, you wrote:
> =20
>
>>Hi,
>>
>>   =20
>>
>>>Hi,
>>>
>>>On Wednesday 10 of August 2005 21:47, Thomas Hellstr=C3=B6m wrote:
>>>     =20
>>>
>>>>Thomas Hellstr=C3=B6m wrote:
>>>>       =20
>>>>
>>>>>Hi!
>>>>>
>>>>>Attached is a patch that stops a drm client from registering a fb /
>>>>>agp memory block under an arbitrary context handle, which will lead =
to
>>>>>heap memory leaks if the client dies.
>>>>>
>>>>>It also stops malicious clients from freeing other clients fb / agp
>>>>>memory blocks.
>>>>>
>>>>>Works fine with via, but it will break sis bsd, so I'll hold off wit=
h
>>>>>commiting. Could someone test on SiS hardware?
>>>>>
>>>>>/Thomas
>>>>>         =20
>>>>>
>>>>I'm commiting the security fix for VIA. SiS will have to be updated b=
y
>>>>someone having that hardware.
>>>>       =20
>>>>
>>>Hi,
>>>
>>>I have problem inserting via drm module after recent commit:
>>>
>>>on modprobe I get:
>>> FATAL: Error inserting via
>>>(/lib/modules/2.6.12-gentoo-r7/kernel/drivers/char/drm/via.ko): Unknow=
n
>>>symbol in module, or unknown parameter (see dmesg)
>>>
>>>in dmesg there is:
>>>[drm] Initialized drm 1.0.0 20040925
>>>via: Unknown symbol drm_check_context
>>>
>>>Michal
>>>     =20
>>>
>>Did you do a "depmod -ea" and reload the new drm.ko?
>>   =20
>>
>
>
>yes, i stopped X, than=20
>rmmod via drm=20
>and finally
>modprobe via
>
>It happened with linux 2.6.12.3 kernel and drm downloaded from cvs 30 mi=
nutes=20
>ago. Module was built on x86 with gcc 3.4.4.
>
>Michal
> =20
>
Doh!

Fixed and commited now.

/Thomas