From: Ian R. <id...@us...> - 2005-05-27 17:49:07
|
Lukas Hejtmanek wrote: > drm_stub.c version 1.52 contains check whether device is AGP. I have i915 card > that is PCIE and it fails to initialize i915 module. If I comment out check for > AGP then everything is OK. That's interesting. I guess the problem is that the i915 driver has DRIVER_REQUIRE_AGP set. I'm not sure what the right answer is here. Even though my change to drm_stub.c broke the Linux version, the BSD version *already* had that same check (and was therefore already broken in the same way). I suspect we may need to change the way drm_device_is_agp works. Right now, the drm_driver::device_is_agp function can only fail a device that would have otherwise passed. Changing the return code of drm_driver::device_is_agp from meaning {"might be AGP", "abosolutely not AGP"} to a tri-state meaning {"absolutely is AGP", "might be AGP", "abosolutely not AGP"} might do the trick. Keith, since you're the main i915 guy, what do you think? Would this bug also effect Via PCI-e chipsets with integrated graphics? |