From: Benjamin H. <be...@ke...> - 2005-01-18 03:23:03
|
On Fri, 2005-01-14 at 12:23 -0500, Michel D=E4nzer wrote: > On Fri, 2005-01-14 at 16:34 +0100, Jerome Glisse wrote: > >=20 > > Anyway i wanted to ask mesa folks how to make a real > > proper patch. The fact is that INREG & OUTREG in > > server/radeon_macros.h have to do endian swapping. > > Moreover the swapping is only needed for r300, isn't it ? > > So do we need to have our own copy of radeon_macros.h > > insted of using the one from dri/radeon/ ? >=20 > No. Try this patch, which is quite ugly though, most of this shouldn't > be in driver specific code IMHO. Gack ! You mean that the DRI doesn't use eieio for accessing MMIO registers ? I have missed that. This is really bad. All 3 sizes, both reads and writes, need to have eieio. Ben. |