From: Ian R. <id...@us...> - 2003-10-21 19:51:55
|
Keith Whitwell wrote: > Would you consider creating a DRM_RADEON_SETPARAM ioctl instead of > DRM_RADEON_FB_LOCATION, with an ioctl struct like: > > #define RADEON_SETPARAM_FB_LOCATION 1 > > typedef struct drm_radeon_setparam { > int param; > int value; > } drm_radeon_setparam_t; If this is done, I would *strongly* suggest that the type of value by int64_t or something similar. We have enough places where mixed 32/64 systems will break, we don't need to add more. On PPC64 where mixed mode is supported, sizeof(int) != sizeof(void*). I assume the same is true on IA-64, x86-64, and SPARC64. Other than that, I am in favor of adding this as a more generic interface. |