[Dri-devel] Re: fixing pageflipping in mergedfb modes

[Alex D. <ag...@ya...>]

--- Michel D�nzer <mi...@da...> wrote:
> On Thu, 2003-10-02 at 18:41, Alex Deucher wrote: 
> > I'm attempting to fix pageflipping in certain mergedfb modes. 
> right
> > now it only works in when crtc2 is right of crtc1.  I suspect the
> > problem has to do with the CRTC offsets that are set in
> > RADEONDoAdjustFrame()
> > 
> > for instance if I have crtc2 left of or above crtc1, I would need
> to
> > adjust RADEON_CRTC_OFFSET by something like
> (crtc2_mode->CrtcHDisplay *
> > crtc2_mode->CrtcVDisplay) right?  and for clone mode, I'd have to
> > adjust the offsets depending on the modes of each head.  is my
> thinking
> > right here?  or does it work differently?
> 
> I wouldn't think anything like this should be necessary as long as
> the
> values passed to RADEONDoAdjustFrame() are virtual screen
> coordinates,
> but you may have become more competent than me in this area. :)
> 

I would have thought the same thing as well, but Xv required that I
take into account the width of crtc2 when using the overlay on crtc1 in
"leftof" mode.  I'm seeing similar behavior when using pageflipping
(the framebuffer is offset on crtc1) in "leftof" mode so that may
require a similar fix.  I'll report back when I mess with it a bit
more.

> 
> > Also, looking at radeon_dri.c, RADEONDRIFinishScreenInit() could we
> cap
> > the 3D engine to 2048x2048 my adjusting the values of
> pRADEONDRI->width
> > and pRADEONDRI->height?  something like:
> > 
> > if (pScrn->virtualX > 2048)
> >     pRADEONDRI->width             = 2048;
> > else
> >     pRADEONDRI->width             = pScrn->virtualX;
> > if (pScrn->virtualY > 2048)
> >     pRADEONDRI->width             = 2048;
> > else
> >     pRADEONDRI->width             = pScrn->virtualY;
> 
> I doubt this would have a useful effect, if any (do the Radeon 3D
> drivers even use these fields?). As I have hinted repeatedly before,
> the
> only sane way to handle this for now is probably to disable the DRI
> if
> either virtual dimension exceeds 2048.
> 

Yeah, that's what I figured, I say the code and thought I would ask. 
I'll dif further this weekend.

thanks,

Alex


__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com