Re: [Dri-devel] Confusion about some code in driCreateContext

[Keith W. <ke...@tu...>]

Ian Romanick wrote:
> I'm making the change I mentioned earlier to the way screens / contexts 
> / drawables are created by the driver.  In doing so I came across some 
> very curious code in driCreateContext (in lib/GL/dri/dri_util.c).  Early 
> in the function there is an if-statement that begins 'if 
> (!psp->dummyContextPriv.driScreenPriv) {'.  In the if-statment 
> driScreenPriv is set to a non-NULL value.  Then, a little later in the 
> function, an almost identical if-statement appears.
> 
> The only "magic" that happens is a call to XF86DRICreateContext 
> inbetween.  At least on the r200 driver, I could not get the second 
> if-statement to ever evaluate to true.  Is it even needed?  Looking at 
> the CVS log, the code has been this way since this file was created.  It 
> looks like this file was moved from somewhere else in the mesa-3-5-branch.

It's not clear how it could change...  The file was previously in I think 
lib/GL/mesa/dri.

Keith