Re: [Dri-devel] [PATCH] mga strips/fans

[<sy...@sc...>]

On Tue, Jul 29, 2003 at 10:42:02AM -0600, Keith Whitwell wrote:
> Ville Syrj=E4l=E4 wrote:
> > This patch enables triangle strips and fans support on G400.
> >=20
> > - New drm should be compatible with old userspace and vice versa.
> >=20
> > - I threw that cull_dualtex stuff out. I moved the spcial case to
> > EmitHWStateLocked() and it's only used when an old drm is detected. I=
t
> > is needed because the old drm swaps the WARPs with dualtex for some
> > reason. I also changed the drm's WACCEPTSEQ dualtex value to 0x1c0000=
00
> > from 0x1e000000. I don't think there's any need to touch seqlen. Only
> > wfirsttag needs to be toggled.
>=20
> Ugh - these are pretty major changes.  How thoroughly have you tested t=
hem?

Mesa demos, quake3, freespace2 and some other stuff.

> The WARP is swapped because the 2nd warp is designed for dual texturing=
.

I got the impression from the docs that both WARPs are used regardless of
texturing mode. And with strips and fans the WARPs aren't swapped. But
then again I can't be sure what's really going on under the hood since th=
e
full docs aren't available...

> > - I changed the dualtex fan WACCEPTSEQ value to the one used in the W=
ARP
> > DDK. I'm not entirely sure about this but I suspect the change was ne=
eded
> > due to the cull_dualtex stuff. I only have single tex + fan apps so I=
'll
> > have to write a test for this...
>=20
> Hmm.  This might be reverting the fix to the infamous G400 q3 lockup.  =
Be sure=20
> to play many hours of quake with this test before considering it right.

I haven't seen quake3 using fans or strips at all...

> It's=20
> probably worth checking back to see exactly what the fix to this bug wa=
s, but=20
> we definitely had to go against what the DDK said to fix it.

Is it mentioned in cvs logs somewhere? I tried to look at the
mga-0-0-1-branch logs but It seems that most of these changes to the=20
WARP DDK values were done in utah-glx...

I'm pretty sure that the WVRTXSZ values are wrong in the DDK since they
would use a lot of reserved bits...

--=20
Ville Syrj=E4l=E4
sy...@sc...
http://www.sci.fi/~syrjala/