From: Andreas S. <A.S...@gm...> - 2003-06-23 16:15:50
|
thanks a lot! btw, I got the 3rd TMU working with hw-tcl and codegen, too. (at least multiarb.c works) I'm going to clean the patch up a bit, so that it only contains things related to 3rd TMU support. Am 2003.06.23 12:17:26 +0200 schrieb(en) Michel D=E4nzer: > On Sat, 2003-06-21 at 14:14, Andreas Stenglein wrote: > >=20 > > [...] some comments where I dont know what to do. >=20 > I'll try to address some of them: >=20 > > + if( (sPriv->drmMinor < 3) || (getenv( "RADEON_NO_3RD_TMU")) ) /* > > question: is the check for drmMinor necessary? */ > > + ctx->Const.MaxTextureUnits =3D 2; > > + else > > + ctx->Const.MaxTextureUnits =3D RADEON_MAX_TEXTURE_UNITS; /* 3 */ >=20 > Does the 3rd TMU require any DRM support not present before that minor > version? I dont know ;) I think I have to try if 3rd TMU works when=20 RADEON_COMPAT is set. On the other hand I think DRI from stock XFree86 4.3.0 wont even work with old radeon.o kernelmodules... Is there a list which versions of the drm-modules were distributed? (linux 2.4, 2.5, bsd x.x, XFree86 4.x.x, GATOS etc.) >=20 >=20 > > + /* question: shouldn't the following be controlled by the > > kernelmodule */ > > + /* and/or Xserver-configuration if it can crash the card? */ > > else if (getenv("RADEON_TCL_FORCE_ENABLE")) { > > fprintf(stderr, "Enabling TCL support... this will probably > > crash\n"); > > fprintf(stderr, " your card if it isn't capable of > > TCL!\n"); >=20 > Why? :) >=20 > I do wonder if trying to enable HW TCL makes sense though, there was a > bit of confusion about TCL support on the various chips at the time. > Maybe we can clean this up with the new config infrastructure. I think that wont help: some_bad_user could put that code back and install his own radeon_dri.so to lockup the graphicscard of a workstation he only has user-rights to. So access to hw-accelerated 3d has to be restricted to trusted users, at least if you have a card without tcl. >=20 >=20 > > + init_rgba_st_st_st(); > > + init_rgba_spec_st_st_st(); > > + init_st_st_st_n(); > > + init_rgpa_spec_st_st_st_n(); /* question: don't know what "rgpa" > > is, just copied and modified.. */ > > + init_rgba_stq_stq_stq(); > > + init_w_rgpa_spec_stq_stq_stq_n(); >=20 > Looks like a typo? Maybe, but its in the r200 sources as well. >=20 >=20 > --=20 > Earthling Michel D=E4nzer \ Debian (powerpc), XFree86 and DRI developer > Software libre enthusiast \ http://svcs.affero.net/rm.php?r=3Ddaenzer >=20 >=20 greetings, Andreas |