From: Michel <mi...@da...> - 2003-06-12 23:54:00
|
On Fri, 2003-06-13 at 00:31, le...@nt... wrote: > On Fri, Jun 13, 2003 at 12:00:12AM +0200, Michel D?nzer wrote: > > >It has no choice > > but to take the data as it gets it from the client? > > Yes, but initially, the interesting piece of a header is the first char, and > the kernel checks the first char (and then correctly skips the length of the > union when it "knows" that the rest of the header doesn't apply to this > particular type) hence it doesn't matter diddly squat what the value of the > other bytes are. > > They are used on different headers, yes - but if there are packets output that > aren't filling in all the data, passing zero instead of whatever the value > should be is no more likely to work, is it? Unless some other code assumes the fields are cleared... > AFAICT that's how it works at least from memory of May 2002. > > Here's the cvs diff, as I say, it wasn't added to fix anything, just to avoid > confusion when looking at the output of verbose - although on first glance at > the verbose output I similary thought it was a bug. Well, if it's purely cosmetic, that's something even I might consider worth a comment. :) -- Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer |