Re: [Dri-devel] cvs sponsor for portability patches

[Keith W. <ke...@tu...>]

Philip Brown wrote:
> If I were to spend the time to put together some portability patches
> [for the kernel layer], would someone with cvs access volunteer interest to
> review and put them in?  I can potentially see a bunch of little ones
> coming up, so rather than post every single one individually to the list, I
> thought I'd suggest a more one-to-one chain.
> 
> For example, I'd like to submit a patch set to fix the issue where
> there is _DRM_LOCK_IS_HELD() calls all over the place, but there really is
> only one syntax for it:
> 
> _DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)
> 
> It would be more portable if it were simply
> 
> _DRM_LOCK_IS_HELD(dev)
> 
> 
> There are at least 9 files that would need minor tweaks for this to be
> cleaned up. Probably more like 15.
> I'm happy to generate a clean set of patches, if someone's actually going
> to bother to put it into cvs.

I'd prefer seperate, clean patches that do a single, selfcontained change.

The change you mention above sounds reasonable -- post a patch to the 
dri-devel list for review.  If it is sane, I'll commit it.

Keith