Re: [Dri-devel] radeonFlushVertices restores the neutral vtxfmt wrapper

[Keith W. <ke...@tu...>]

Felix K=FChling wrote:
> Hi,
>=20
> while I was trying to understand the vtxfmt mesa code and poking around
> with gdb I noticed that the neutral vtxfmt wrapper gets restored quite
> often. I tracked it to radeonFlushVertices where
> _mesa_install_exec_vtxfmt( ctx, &rmesa->vb.vtxfmt ) is called if the
> FLUSH_UPDATE_CURRENT flag is set. _mesa_install_exec_vtxfmt in turn set=
s
> ctx->TnlModule.Current to the new exec vertex format and calls
> _mesa_restore_exec_vtxfmt( ctx ) which restores the neutral wrapper. Is
> this really what was intended here?
>=20
> The only place I could find where the FLUSH_UPDATE_CURRENT flag is set
> in the radeon driver is in radeon_vtxfmt_c.c and there the Exec dispatc=
h
> table is modified directly. So there should be no need for reinstalling
> the vertex format.

It is necessary to do that there.  I can't bring an example off the top o=
f my=20
head, but feel free to remove the call & play with the mesa demos.  Somet=
hing=20
should break before too long...

I guess I should have left a comment there to explain/remind myself why.

Keith