Re: [Dri-devel] r128 textures

[Henry W. <haw...@at...>]

Leif Delgass wrote:

>On 17 Jul 2002, Michel Dänzer wrote:
>
>>>>I just updated to today's build and texture colors look fine on r128 in
>>>>x86.  Also, we had reports that the changes made in Mesa on the trunk
>>>>(which we merged into the mach64 branch) fixed textures on ppc for mach64,
>>>>which has a choose texture function based on r128.
>>>>
>>>Since the merge, the radeon PPC fixes added an additional swap in the 
>>>texture path for BE systems.
>>>
>>If I understand correctly, the endianness fixes are the Mesa changes
>>Leif referred to.
>>
>
>Right.  The merge from the trunk to the mach64 branch was done June 26 -- 
>after the endianess fixes.
>
1> I can find no extra byte swapping being done to textures in the r128 
code and
     dword swaps at later point in the pipeline would break 16 and 8 bpp 
textures.

2> The r128 texture code works without PACK*LE works on  both LE and BE
      systems in both 32bpp and 16bpp. None of the code I had to change 
except
      the PACK*LE would affect textures.

3> Any change that I can see to make to work with the PACK*LE would have
      to be conditional on endiness to not break x86. But that would be 
redundant!

4> Something is wrong, but where?