Re: [Dri-devel] Radeon scratch register writeback patch

[Keith W. <ke...@tu...>]

Michel D=E4nzer wrote:
> On Fri, 2002-07-12 at 14:56, Keith Whitwell wrote:=20
>=20
>>>Looks good, but I think I've got an even better patch:
>>>
>>>http://www.penguinppc.org/~daenzer/DRI/radeon-nommio.diff
>>>
>>>I've moved the initialization and put the scratch registers right behi=
nd
>>>the ring read pointer, this should work with PCI GART and all kinds of
>>>AGP GART. I'll commit this now.
>>>
>>This looks ok.  The one thing I'd say is that we've added functionality=
 to the=20
>>kernel module, so we should bump the minor version number (ie 1.4.0) --=
 this=20
>>means that you can test rmesa->drm.minor (or whatever) instead of firin=
g off=20
>>the ioctl & checking for EINVAL.
>>
>=20
> Bumping the minor strikes me as overkill for this. It's not a new ioctl
> or something. What about the attached patch?

It's a change to the interface -- an extension.  It doesn't matter that i=
t's=20
not a new ioctl, this is exactly what bumping the minor number is suppose=
d to=20
do.  Bumping the minor number is free - it doesn't cost anything or break=
=20
anything.

One thing that we haven't really made clear is when a 'release' is.  Howe=
ver,=20
given that 1.3 is in the 2.5 kernel sources, I'd say wherever the line is=
,=20
we've crossed it.  So - bump the minor & don't worry too much.

Keith