From: Alan H. <al...@fa...> - 2002-05-20 15:15:30
|
On Mon, May 20, 2002 at 03:22:52PM +0100, Keith Whitwell wrote: > > > > I've got some time to take a look at this over the next couple of days. It > > > really depends how big the differences are - but probably we need to come up > > > with a way of doing things without too much #ifdef crud in the main code -- > > > whether this means we need an abstraction layer, more templating to account > > > for OS differences, or other, I don't know. I don't really like the seperate > > > directories idea as this means it is easy for them to get out-of-sync. > > > > Keith, do you mean directories out of sync with each other, or out of > > sync with their respective kernel repositories? > > I mean out of sync with each other. I don't think it's a good idea to > duplicate code in our repository. > > > > I'd > > > rather have the core logic in one place only, and have OS-specifics somehow > > > mixed in. > > > > If we had everything in one directory, would the kernel maintainers > > accept all the files, or would they end up pruning out the OS specific > > files they weren't interested in? > > We'd probably have to have some way to generate 'pure' versions for kernel > maintainers. That would also include getting rid of the current > LINUX_VERSION_CODE bumf prior to submitting (on the linux side of things) Back when I did all the templating work for FreeBSD I wrote a utility that I passed to Eric that does the stripping out of the ifdef stuff and creating the pure linux code. Alan. |