Re: CVS Update: drm (branch: trunk)

[Eric A. <et...@lc...>]

On Tue, 2005-11-08 at 12:25 -0800, Eric Anholt wrote:
> CVSROOT:	/cvs/dri
> Module name:	drm
> Repository:	drm/shared-core/
> Changes by:	anholt@gabe.	05/11/08 12:25:00
>=20
> Log message:
>   Initial port of savage to FreeBSD for the AGP and !ShadowStatus case.  =
Adds
>   drm_mtrr_{add,del} for handling the MTRR setup.  Still has a LOR issue =
with
>   DRM_VERIFYAREA_READ/DRM_COPY_FROM_USER_UNCHECKED in savage_bci.c -- thi=
s won't
							^^
that should read savage_state.c.  Also, for those playing at home, "LOR"
means "lock order reversal" -- one of a few different ways of getting
the fine-grained locking in FreeBSD wrong.

>   work with the fine-grained locking in use, and just doing a single copy=
in to a
>   temporary will probably work fine.  Also note that the module leaks
>   approximately 4 kb on unload.


--=20
Eric Anholt                                     et...@lc...
http://people.freebsd.org/~anholt/              anholt@FreeBSD.org