[Dri-devel] RE: agpgart/DRM page_mask cleanup

[Jeff H. <jha...@ad...>]

Just a few quick comments, it looks like you removed the need for the
num_of_masks variable inside the agp_bridge structure.  I'd prefer to remove
this entirely if all places where it is referenced are removed.  There are
advantages to doing the masking beforehand, however at the moment inserting
and removing agp memory is not very important to the DRI.  This might not be
the case forever though.  Perhaps allowing the chipset to decide the
behavior would be the best solution.

-Jeff

-----Original Message-----
From: Bjorn Helgaas [mailto:bjo...@hp...]
Sent: Monday, February 11, 2002 10:31 AM
To: Jeff Hartmann
Cc: Chris Ahna; dri-devel
Subject: agpgart/DRM page_mask cleanup


This patch makes it possible for agpgart/DRM to support the
460GX without a chipset-specific wart in DRM.

I've sent variants of this around before, but everybody wants your
opinion, Jeff :-)  Any comments would be greatly appreciated.
--
Bjorn Helgaas - bjo...@hp...
Linux Systems Operation R&D
Hewlett-Packard