From: Keith W. <ke...@va...> - 2001-06-01 16:51:38
|
Brian Paul wrote: > > Keith Whitwell wrote: > > > > Brian Paul wrote: > > > > > > CVSROOT: /cvsroot/dri > > > Module name: xc > > > Repository: xc/xc/lib/GL/mesa/src/drv/tdfx/ > > > Changes by: brianp@usw-pr-cvs1. 01/06/01 09:21:32 > > > > > > Log message: > > > removed multipass loop from render tab functions, fixes gloss, spectex, etc > > > > The loop should stay -- it may be broken, but it should be fixable -- it's > > required for iterating over cliprects in the driver. > > It's redundant. The multipass clip loop is already done at a higher > level via the tnl run_render() function. As it was, primitives were > being rendered 2X times. Apps which did blending, like gloss, were > showing the problem. > > It appears to me that the tdfx_render_vb_*() functions can only be > called via the tnl->Driver.RenderTabVerts pointer and that pointer > is only used inside the multipass loop in run_render(). If there's > another way for the tdfx_render_vb_*() functions to be called then > we've got a problem to fix. No, that sounds correct... I just had a braino... Thanks, Keith |