Menu

#103 configure_test_cpu returns incorrect error code.

MCRB
closed
nobody
None
2017-02-11
2016-02-25
No

'configure_test_cpu' does many checks and returns a wide variety of error codes, two of which are shown here:

      if ^found then do;                                /* didn't find mask */
           rcode = rcerr_isolts_no_mask;
           return;
      end;

and

      call set_procs_required (cpu_mask, tcode);
      if tcode ^= 0 then do;
           rcode = rcerr_sprq_failed;
           return;
      end;

Looking in rcerr.incl.pl1, we see:

 rcerr_sprq_failed init (17)                            /* could not set CPU required */

and

 rcerr_isolts_no_mask init (17)                         /* No mask set for test cpu */

Every other error code used in 'configure_test_cpu' is of the form 'rcerr_isolts_xxxxx'.

The following line needs to be added to rcerr.incl.pl1:

 rcerr_isolts_sprq_failed init (18)                     /* could not set CPU required */

The line in configure_test_cpu.pl1:

           rcode = rcerr_sprq_failed;

needs to be changed to:

           rcode = rcerr_isolts_sprq_failed;

Discussion

  • Charles Anthony

    Charles Anthony - 2016-02-25

    The 'rcode = rcerr_sprq_failed;' line occurs twice in configure_test_cpu.pl1.

     
  • Eric Swenson

    Eric Swenson - 2017-02-11

    Closing as ticket moved here: http://multics-trac.swenson.org/ticket/30

     
  • Eric Swenson

    Eric Swenson - 2017-02-11
    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB