#405 Change job number fails - "Could not rename job folder"

[Terry O'Neill]

The "Change Job Number" functionality fails with the message "Could not rename job folder"

This appears to be because of the usage of the java.io.File.renameTo function. This function looks to not support renaming files over a network or over a File-System boundary. This should be altered to use a different method to move files and tested on various different types of mounted File Systems.

[Terry O'Neill]

Note that for file copying used elsewhere in DPR copying specifically through Streams is used with comments to say this is to avoid issues with copying over a network.

Also note that it seems likely that as part of the solution for rfe-3552272 that Apache Commons VFS will be used which may be an appropriate alternative. Also note that after upgrading to Java 7 it may also be worth considering the new NIO 2 functionality for this purpose.

Finally note prior to the fix for bug-3514326 (present in DPR version 5.1.0) it is possible to change a job number which will change the database but not the file system. It is then possible to change the file system location manually. This method can be used to change job numbers prior to the upgrade to version 5.1.0 if so desired.

[Terry O'Neill]

After performing some renumbering of jobs with Sean today it appears that the renameTo function does not prevent renaming on a mounted drive. However it would still be good to alter this functionality (particularly to improve error messages). Note that with planned changes for rfe-3552272 the way this renaming is done should be altered anyhow which should remove this issue. For this reason I am lowering the priority of this bug.