Re: [Dpp-devel] Review Request: Automatically open the currently opened file of the followed user when starting to follow

[Alexander W. <co...@ne...>]

> On Jan. 23, 2012, 12:54 a.m., Hendrik Degener wrote:
> >

Please re-test the patch.
When there are more than 2 participants in one session, the follow mode button automatically (randomly) follows the first user that has write access (no change of status quo).
In case there is only one driver with write access (e.g. the host) everyone would automatically follow that user when they click on the icon, unless they specifically choose a different user to follow.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/234/#review750
-----------------------------------------------------------


On Jan. 29, 2012, 12:28 p.m., Alexander Waldmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/234/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 12:28 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> Added automatically "jumping to users current position" when following a user. This is the expected behaviour of the follow mode.
> 
> After evaluating several videorecorded sessions of saros sessions, it quite regularly happened that the driver that is being followed started talking about the file he/she has currently opened, whereas the following user did not yet see that file, since there has been no "change" in open editors on the drivers side. Users had to open the contextmenu twice to achieve the desired result (following+immediately seeing the same thing as the followed user)
> 
> I did NOT add that all open editors are synced with the followed user, which could also be seen as "expected behaviour" (i.e. when following someone, all files that this user has opened are opened on my host too).
> 
> 
> Diffs
> -----
> 
>   trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/FollowModeAction.java 3706 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/234/diff
> 
> 
> Testing
> -------
> 
> Manually testing done.
> 
> 
> Thanks,
> 
> Alexander
> 
>