[Dpp-devel] Review Request: [FEATURE] New whiteboard features

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/195/
-----------------------------------------------------------

Review request for Saros and SWTP.

Changes
-------

I hope the original authors don't mind, but I took the liberty of updating the patch with review feedback. The review didn't seem to be moving forward and I took the initiative -- the risk is that the whole patch goes out of date and becomes absolute hell to update. The patch is now "fresh" again.

I addressed Stefan's feedback and took the opportunity to correct some other stuff too.

Testing: Ran it in a test session, but some features didn't seem to work:
  - textbox and annotation: the pointer icon became a 'x' as though something was wrong - clicking popped up a textbox to enter text, but it didn't appear after entering it
  - panning: I expected to be able to move the canvas by clicking and dragging, but nothing happened.

Summary
-------

Submitted on behalf of team 2 - Warning: this description may be incomplete. I have asked team 2 for a full description of this feature, but received no reply yet. Someone from Team 2, please update this description!

New drawing features introduced:
- Straight line
- Straight line with arrow-head
- Text
- Annotation
- Drawing done in your session colour

Diffs (updated)
-----

  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/de.fu_berlin.inf.dpp.whiteboard.application-stanalone_x64.launch PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/actions/ChangeBackgroundColorAction.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/actions/ChangeForegroundColorAction.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/actions/ColorListener.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/commands/AbstractElementRecordCreateCommand.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/commands/ElementRecordCreateCommand.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/commands/SXECommand.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/commands/TextboxCreateCommand.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/editor/WhiteboardEditor.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/editpolicy/ElementModelLayoutEditPolicy.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/editpolicy/XYLayoutWithFreehandEditPolicy.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/model/GEFRecordFactory.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/model/SVGAnnotationRecord.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/model/SVGEllipseRecord.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/model/SVGPolylineRecord.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/model/SVGRectRecord.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/model/SVGTextBoxRecord.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/ElementRecordPart.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/RecordPartFactory.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/SVGAnnotationPart.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/SVGEllipsePart.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/SVGPolylinePart.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/SVGRectPart.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/SVGTextBoxPart.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/request/CreateLineRequest.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/request/CreatePointlistRequest.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/request/CreateTextBoxRequest.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/tools/ArrowCreationTool.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/tools/CreationToolWithoutSelection.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/tools/LineCreationTool.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/tools/TextboxCreationTool.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/util/ColorUtils.java PRE-CREATION 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/gef/util/IconUtils.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/net/WhiteboardManager.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/standalone/Application.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/standalone/ApplicationWorkbenchAdvisor.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/standalone/ApplicationWorkbenchWindowAdvisor.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/standalone/WhiteboardActionBarContributor.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/standalone/WhiteboardContextMenuProvider.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/sxe/SXEController.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/sxe/net/SXEMessage.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/sxe/net/SXEOutgoingSynchronizationProcess.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/sxe/records/ChildRecordChangeCache.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/sxe/records/DocumentRecord.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/sxe/records/NodeRecord.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/src/de/fu_berlin/inf/dpp/whiteboard/view/SarosWhiteboardView.java 3613 
  /trunk/dpp/de.fu_berlin.inf.dpp.whiteboard/srclib/org/apache/batik/util/SVGConstants.java 3613 

Diff: http://saros-build.imp.fu-berlin.de/reviews/r/195/diff

Testing
-------

Thanks,

Karl