Re: [Dpp-devel] Review Request: [FIX] 3348926: Whiteboard doesn't expand the painting area

[Karl B. <be...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/191/#review530
-----------------------------------------------------------

Ship it!


NOTE: Be careful when creating patches. You created this patch from within an old release branch, and the patch root was a subfolder rather than the project root (I had to apply the patch directly to the "gef" folder.)

Anyway, works for me. No detected side-effects.

- Karl


On Sept. 26, 2011, 11:01 a.m., hdegener wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/191/
> -----------------------------------------------------------
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> This patch solves the problem of the whiteboard not properly expanding the painting area when needed.
> It works by exchanging the RootEditPart of the graphical viewer (into ScalableFreeformRootEditPart) and adapting the corresponding root figure (delivered by SVGRootPart.createFigure()).
> Small, straightforward patch with about 10 changed lines of code.
> 
> 
> This addresses bug 3348926.
>     http://sourceforge.net/support/tracker.php?aid=3348926
> 
> 
> Diffs
> -----
> 
>   branches/dpp.whiteboard_11.7.29.r3479/src/de/fu_berlin/inf/dpp/whiteboard/gef/editor/WhiteboardEditor.java 3562 
>   branches/dpp.whiteboard_11.7.29.r3479/src/de/fu_berlin/inf/dpp/whiteboard/gef/editpolicy/ElementModelLayoutEditPolicy.java 3562 
>   branches/dpp.whiteboard_11.7.29.r3479/src/de/fu_berlin/inf/dpp/whiteboard/gef/part/SVGRootPart.java 3562 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/191/diff
> 
> 
> Testing
> -------
> 
> Windows session with 2 participants
> 
> 
> Thanks,
> 
> hdegener
> 
>