Menu
▾
▴
Re: [Dpp-devel] Review Request: [INTERNAL] Refactored Saros class to move network related code to class SarosNet
|
From: srossbac <sro...@in...> - 2011-07-17 19:36:45
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/107/#review244 ----------------------------------------------------------- Ship it! I know it was a bit rude, but i think it is a good practice if you are refactoring some old code to update the documentation as well if possible. +1 - srossbac On July 17, 2011, 9:32 p.m., gustavs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/107/ > ----------------------------------------------------------- > > (Updated July 17, 2011, 9:32 p.m.) > > > Review request for Saros. > > > Summary > ------- > > This patch is refactoring the Saros class to move all network related code to the specialized class SarosNet. > SarosNet is introduced into the picocontainer. > So the Saros plugin class does not contain network stuff, so network functionality and tests dont depend on the complete Saros plugin anymore. > > This refactoring affects many classes that did some call on Saros, doing that call on SarosNet now. So changes of many files in the diff are trivial. Dont be shocked. > > I added a junittest which creates two SarosTestNet instances, each consisting of "a network layer". The test establishes and tests the connection to the XMPP server. > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/Saros.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/SarosContext.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/User.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/communication/SkypeManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/communication/muc/MUCManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/concurrent/watchdog/ConsistencyWatchdogServer.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/IConnectionListener.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/ITransmitter.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/RosterTracker.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/SarosNet.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/UPnP/UPnPManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/ConnectionTestManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/DataTransferManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/Socks5Transport.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/StreamServiceManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/StreamSession.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/TransferDescription.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/XMPPReceiver.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/XMPPTransmitter.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/discoveryManager/DiscoveryManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/subscriptionManager/SubscriptionManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/util/RosterUtils.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/preferences/PreferenceUtils.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/SarosSession.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/propertyTesters/SarosPropertyTester.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/serviceProviders/SarosSourceProvider.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/LocalPresenceTracker.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/ChangeXMPPAccountAction.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/ConnectionTestAction.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/DeleteContactAction.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/NewContactAction.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/RenameContactAction.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/menuContributions/ProjectShareBuddies.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/views/SarosView.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/ConnectionStateComposite.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/viewer/roster/BaseBuddySelectionComposite.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/viewer/roster/BuddyDisplayComposite.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/widgets/viewer/rosterSession/BuddySessionDisplayComposite.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/AddBuddyWizard.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/CreateXMPPAccountWizard.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/InvitationWizard.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/pages/AddBuddyWizardPage.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/pages/InvitationWizardUserSelectionPage.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/util/VersionManager.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/util/log/JIDFileAppender.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/test/framework/stf/src/de/fu_berlin/inf/dpp/stf/server/rmi/superbot/component/view/saros/impl/SarosView.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/net/RosterTrackerTest.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/net/internal/InternalTestSuite.java 3472 > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/net/internal/SarosNetConnectTest.java PRE-CREATION > /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/net/internal/SarosTestNet.java PRE-CREATION > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/107/diff > > > Testing > ------- > > manual, junit > > > Thanks, > > gustavs > > |