Re: [Dpp-devel] Review Request: [ADDED] AbstractSarosUnitTest - Bring the very first simple tests to run

[Karl B. <be...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/100/#review221
-----------------------------------------------------------


I seem to be missing de.fu_berlin.inf.dpp.test.xmpp.* when I apply this patch and cannot find it in any other patches.

- Karl


On July 6, 2011, 8:33 p.m., Philipp Cordes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/100/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 8:33 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> With this patch we introduce a new abstract class which will be the central point for coming functionality which makes the writing of new unit-tests more comfortable.
> 
> When you want to create a new test class you only must set this as subclass of AbstractSarosUnitTest. 
> Than when you run tests there will be automatically start a local XMPP-Server with which possibly created test-instances can communicate.
> 
> I also added a simple method for getting a full configured test-instance. But this method will be replaced later by a separate class which will provide different and more complex types of scenario-creation.
> 
> To reuse the initialization of the PreferenceStore I refactored the PreferenceInitializer to do it's job in more abstract way. So it can now initialize instances from type IEclipsePreferences AND IPreferenceStore.
> 
> For a better understanding look at the simple Test: BasicFrameworkTest
> 
> 
> Diffs
> -----
> 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/Saros.java 3450 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/SarosContext.java 3450 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/preferences/PreferenceInitializer.java 3450 
>   /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/context/TestSaros.java 3450 
>   /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/net/BasicFrameworkTest.java PRE-CREATION 
>   /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/util/AbstractSarosUnitTest.java PRE-CREATION 
>   /trunk/dpp/de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/util/EclipseHelperTestSaros.java 3450 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/100/diff
> 
> 
> Testing
> -------
> 
> BasicFrameworkTest
> 
> 
> Thanks,
> 
> Philipp
> 
>