From: Björn <bjo...@in...> - 2011-02-28 10:40:03
|
> On Feb. 28, 2011, 11:34 a.m., Christian wrote: > > Ok everything looks fine. What I don't understand is why you added this two new methods? Will you need them in future? Correct. My new wizards patch is ready to be reviewed but I don't want to obstruct the review board. All input elements that allow to enter JIDs will be dropdown elements containing a list of already used domains. - Björn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/193/#review523 ----------------------------------------------------------- On Feb. 28, 2011, 4:20 a.m., Björn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/193/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2011, 4:20 a.m.) > > > Review request for All Saros. > > > Summary > ------- > > [FIX] You can now call loadAccounts in XMPPAccountStore multiple times. > Currently the DI and the RosterView called this method which lead to corrupt id. > I reset the maxId in loadAccounts and made the id immutable. > > [INTERN] I also added 2 methods: > One for getting a list of used servers. > A second for getting a list of used domains. > > Both lists only differ in case a user defined an alternative server. > (e.g. username = "ma...@bk...", server = "talk.l.google.com" => getDomains would contain bkahlert.com, getServers would contain talk.l.google.com) > > > Diffs > ----- > > ./src/de/fu_berlin/inf/dpp/accountManagement/XMPPAccount.java 3136 > ./src/de/fu_berlin/inf/dpp/accountManagement/XMPPAccountStore.java 3136 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/193/diff > > > Testing > ------- > > > Thanks, > > Björn > > |