[Dpp-devel] Review Request: [FIX] Use different revisions for detecting and replicating changes.

[Andreas H. <haf...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/148/
-----------------------------------------------------------

Review request for All Saros.


Summary
-------

It is necessary to use different revisions with SVN. This is best explained with an example.

at revision 1, my repository contains folder X, file X/A.
at revision 2, I copied X to Y.
at revision 3, I changed Y/A.
I checkout X.

When I switch A to Y/A@2, the Properties dialog shows the "correct" URL, but there are two revision: The actual revision is 1 ("Last Changed Revision" in the dialog), and the current revision (just "Revision" in the dialog) is 2.
But when I switch A to Y/A@1, it actually switches to X/A@1. The problem is that there is a distinction between current and actual revision, but none between current and actual URL. Both Y/A@2 and Y/A@1 point to the same file X/A@1 in the repository. So it should use Y/A@2 as the current VC state, and X/A@1 as the actual VC state, but unfortunately SVN [doesn't work that way|sucks].

This means that we can't use the actual revision for commands like svn switch. But for detecting changes of the revision, we *should* use the actual revision, because we only get notifications of SyncInfo changes from Eclipse when the actual revision of a resource changes. Which means we need both, the actual revision for detecting changes, and the current revision to replicate these changes, see PDV.


Diffs
-----

  ./src/de/fu_berlin/inf/dpp/FileList.java 2821 
  ./src/de/fu_berlin/inf/dpp/invitation/IncomingInvitationProcess.java 2821 
  ./src/de/fu_berlin/inf/dpp/vcs/SubclipseAdapter.java 2821 
  ./src/de/fu_berlin/inf/dpp/vcs/SubclipseProjectDeltaVisitor.java 2821 
  ./src/de/fu_berlin/inf/dpp/vcs/VCSAdapter.java 2821 
  ./test/src/de/fu_berlin/inf/dpp/stf/server/rmiSwtbot/eclipse/workbench/PEViewComponentImp.java 2821 

Diff: http://saros-build.imp.fu-berlin.de/reviews/r/148/diff


Testing
-------


Thanks,

Andreas