Re: [Dpp-devel] Review Request: Bugfix: inconsitency if dirver leaves/rejoins the session

[Karl B. <kar...@fu...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/104/#review264
-----------------------------------------------------------


-1

Just a little confusion over some text to the user. Also, some possible efficiency savings.

- Karl


On 2010-10-25 18:03:43.380419, Umut Erdogan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/104/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 18:03:43.380419)
> 
> 
> Review request for All Saros.
> 
> 
> Summary
> -------
> 
> > if the driver has unsaved files, leaves and rejoins the session there are inconsistencies
> > - if driver joins with an existing project his opened files are still unsaved
> > - if driver joins with new project not all changes are applied
> 
> Changed to not ask for confirmation for saving of open files of a
> preexisting project for shared project on incoming site. This because to
> not save will prevent from getting the correct file state from the host and
> causes the incosistency.
> 
> I then tried to reproduce inconsistency and some times it was possible.
> Later after inserted debugging statement it was not reproduceable anymore.
> Don't know if it still exist? I haven't see it.
> 
> 
> This addresses bug 2894573.
> 
> 
> Diffs
> -----
> 
>   ./src/de/fu_berlin/inf/dpp/Saros.java 2628 
>   ./src/de/fu_berlin/inf/dpp/editor/EditorManager.java 2628 
>   ./src/de/fu_berlin/inf/dpp/editor/internal/EditorAPI.java 2628 
>   ./src/de/fu_berlin/inf/dpp/editor/internal/IEditorAPI.java 2628 
>   ./src/de/fu_berlin/inf/dpp/invitation/IncomingInvitationProcess.java 2628 
>   ./src/de/fu_berlin/inf/dpp/ui/wizards/JoinSessionWizard.java 2628 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/104/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Umut
> 
>