From: Karl B. <kar...@fu...> - 2010-07-28 08:00:23
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/48/#review103 ----------------------------------------------------------- Ship it! All good here! +1 Regarding the interface: I pretty much agree with you, Andreas. If and when the VCS feature can support multiple users with/without VCS invisibly, then the default should be to include SVN support. We could even then just roll the two menu items into a single "Share project" option. As it is, that option excludes users based on whether they have a plug-in or not, which is a conscious decision the inviter must make. - Karl On 2010-07-28 09:08:40.155160, Andreas Haferburg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/48/ > ----------------------------------------------------------- > > (Updated 2010-07-28 09:08:40.155160) > > > Review request for All Saros. > > > Summary > ------- > > [FEATURE] Peers automatically checkout from SVN if the host shares a project under version control. Both need to have Subclipse 1.6.12 or later installed for this to work. Falls back to the old synchronization mechanism if a checkout isn't possible. > > Note: Other SVN operations like Switch or Update are still not supported. > Not sure if 1.6.12 is really necessary; this can be changed in the manifest.mf (under Dependencies). > > I only tested this locally. I don't know what happens if the peer can't access the repository (bad/missing credentials). > > The point of "Saros_Bob no Subclipse.launch" is to simulate a peer who doesn't have Subclipse installed. I don't know if that's gonna work for everyone; I simply unchecked the subclipse related items in the Plug-ins tab. > > A review before we open up the release branch would be nice. ^_^ > > > Diffs > ----- > > /META-INF/MANIFEST.MF 2293 > /Saros_Bob no Subclipse.launch PRE-CREATION > /plugin.xml 2293 > /src/de/fu_berlin/inf/dpp/FileList.java 2293 > /src/de/fu_berlin/inf/dpp/FileListDiff.java 2293 > /src/de/fu_berlin/inf/dpp/invitation/IncomingInvitationProcess.java 2293 > /src/de/fu_berlin/inf/dpp/invitation/OutgoingInvitationProcess.java 2293 > /src/de/fu_berlin/inf/dpp/project/ISessionManager.java 2293 > /src/de/fu_berlin/inf/dpp/project/ISharedProject.java 2293 > /src/de/fu_berlin/inf/dpp/project/SessionManager.java 2293 > /src/de/fu_berlin/inf/dpp/project/internal/SharedProject.java 2293 > /src/de/fu_berlin/inf/dpp/ui/actions/GeneralNewSessionAction.java 2293 > /src/de/fu_berlin/inf/dpp/ui/actions/NewSessionAction.java 2293 > /src/de/fu_berlin/inf/dpp/ui/actions/NewSessionActionWithVCS.java PRE-CREATION > /src/de/fu_berlin/inf/dpp/ui/actions/PartialNewSessionAction.java 2293 > /src/de/fu_berlin/inf/dpp/ui/wizards/JoinSessionWizard.java 2293 > /src/de/fu_berlin/inf/dpp/vcs/SubclipseAdapter.java PRE-CREATION > /src/de/fu_berlin/inf/dpp/vcs/VCSAdapter.java PRE-CREATION > /src/de/fu_berlin/inf/dpp/vcs/VCSAdapterFactory.java PRE-CREATION > /src/de/fu_berlin/inf/dpp/vcs/VCSProjectInformation.java PRE-CREATION > /test/src/de/fu_berlin/inf/dpp/net/FileListTest.java 2293 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/48/diff > > > Testing > ------- > > > Thanks, > > Andreas > > |