From: Karl B. <kar...@fu...> - 2010-07-26 13:57:15
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/52/#review98 ----------------------------------------------------------- I think it's good for people to know about it, but not such a good idea to include it in our project. - Karl On 2010-07-26 15:31:28.318376, Andreas Haferburg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/52/ > ----------------------------------------------------------- > > (Updated 2010-07-26 15:31:28.318376) > > > Review request for All Saros. > > > Summary > ------- > > There is this tool called Sleak, which detects handle leaks in java applications. It tracks handles for images, fonts, colors etc. You can create a snapshot of the currently allocated handles, and diff after a while. It complains when there are handle leaks when you close it. > http://www.eclipse.org/articles/swt-design-2/sleak.htm > > It's basically a Java class that manages a separate window. I think it's useful for debugging handle leaks, so I added it to Saros. To activate it, you need to enable debugging in SWT, that's why I modified Alice.launch. It uses this file _options for that. It only starts Sleak when assertions are enabled. > > I didn't know a better way to specify the path of the project, but ${project_loc} seems to point to the currently selected project, so make sure you have the right project selected when starting. > > The way I added this to Saros is a bit ugly. I didn't know where to put Sleak.java or the _options file. Also I don't know how to make sure that it won't make it into the release build. Hints/suggestions are welcome. > > > Diffs > ----- > > /Saros_Alice_Host.launch 2298 > /debug/sleak/Sleak.java PRE-CREATION > /debug/sleak/_options PRE-CREATION > /src/de/fu_berlin/inf/dpp/Saros.java 2298 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/52/diff > > > Testing > ------- > > > Thanks, > > Andreas > > |