Re: [Dpp-devel] Review Request: [FEATURE] Open preferences from Saros menu

[Karl B. <kar...@fu...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/50/#review94
-----------------------------------------------------------

Ship it!


+1

Couldn't agree more!

- Karl


On 2010-07-25 10:30:24.323875, Andreas Haferburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/50/
> -----------------------------------------------------------
> 
> (Updated 2010-07-25 10:30:24.323875)
> 
> 
> Review request for All Saros.
> 
> 
> Summary
> -------
> 
> I added an action which opens the Preferences Dialog with the Saros page pre-selected.
> 
> Since we already have a menu, why not use it?
> 
> 
> Diffs
> -----
> 
>   /plugin.xml 2293 
>   /src/de/fu_berlin/inf/dpp/ui/actions/OpenPreferencesAction.java PRE-CREATION 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/50/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas
> 
>