Re: [Dpp-devel] Review Request: Optimise folder deletions

[oezbek <oe...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/12/#review15
-----------------------------------------------------------


-1 as the comparison whether a FolderActivity is nested does not take into account that several projects might be involved with similar paths.

Additional suggestion:

  * Move the code to check whether one Activity is nested to another into the FolderActivity, it belongs rather there

  


./src/de/fu_berlin/inf/dpp/activities/SPathDataObject.java
<http://saros-build.imp.fu-berlin.de/reviews/r/12/#comment6>

    Do not change the API without documenting it.



./src/de/fu_berlin/inf/dpp/net/internal/ActivitySequencer.java
<http://saros-build.imp.fu-berlin.de/reviews/r/12/#comment7>

    The comparison here is not correct, as you only compare the Paths, but not the projects.


- oezbek


On 2010-05-18 16:01:27.731893, Karl Beecher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/12/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 16:01:27.731893)
> 
> 
> Review request for All Saros.
> 
> 
> Summary
> -------
> 
> Currently, when you delete a folder with child folders, Saros transmits individual deletion activities for all folders to the peer.
> 
> This is a small optimisation so that recursive folder deletions are folded into a single activity to be sent to the peer.
> 
> 
> Diffs
> -----
> 
>   ./src/de/fu_berlin/inf/dpp/activities/SPathDataObject.java 2163 
>   ./src/de/fu_berlin/inf/dpp/net/internal/ActivitySequencer.java 2163 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/12/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karl
> 
>