Re: [Dpp-devel] [PATCH] Log-in shows confusing message if jabber id doesn't exist - ID: 2746974

[Marcus L. (FU Informatik) <li...@in...>]

Hi Karl,
thank you for your review. I understand your objections. Attached to this email is my new version. In additions to your doubts I have transferred two others methods to the Util class for which it makes sense too.


Regards,
Marcus


> -----Ursprüngliche Nachricht-----
> Von: Beecher, Karl [mailto:Kar...@fu...]
> Gesendet: Montag, 29. März 2010 13:58
> An: dpp...@li...
> Betreff: Re: [Dpp-devel] [PATCH] Log-in shows confusing message if
> jabber id doesn't exist - ID: 2746974
> 
> I don't like this. -1
> 
> Suddenly compromising the architecture of the class and converting a
> protected method to public static is not the way to go.
> 
> However, I am happy for the contents of the method to be refactored as
> a static utility method; #showConfigurationWizard() can then call this.
> 
> It would be particularly useful to do this, as another separate feature
> we want to implement in the future will need to call the configuration
> wizard.
> 
> Regards
> Karl
> 
> 
> > -----Original Message-----
> > From: Marcus Lindner (FU Informatik) [mailto:lindner@inf.fu-
> berlin.de]
> > Sent: Monday, March 29, 2010 1:20 AM
> > To: dpp...@li...
> > Subject: [Dpp-devel] [PATCH] Log-in shows confusing message if jabber
> > id doesn't exist - ID: 2746974
> >
> > Hello Saros,
> >
> > this is a patch for the following "bug":
> >
> >
> >
> >
> http://sourceforge.net/tracker/?func=detail&aid=2746974&group_id=167540
> > &atid=843359
> >
> >
> >
> > I think it's less a bug, more a feature.
> >
> >
> >
> >
> >
> > Regards,
> >
> > Marcus
> 
> 
> -----------------------------------------------------------------------
> -------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Dpp-devel mailing list
> Dpp...@li...
> https://lists.sourceforge.net/lists/listinfo/dpp-devel