Menu

#862 Saros/I does not compile with IntelliJ 15

OTHER
closed-fixed
IntelliJ (27)
5
2019-12-02
2015-12-07
No

Saros/I does not compile with the newest version (15) of IntelliJ because they changed an internal API. Apparently PropertiesComponent got new interface methods (that we now don't implement).

I would suggest to require IntellIJ 15 for Saros/I, since we have no release yet and would not break any existing installations.

Discussion

  • Holger Schmeisky

    I ran into the following problem:

    IntelliJ 15 ships with JUnit 4.12 (Eclipse uses 4.11), which is incompatible with powermock < 1.6.1 (this can be solved by upgrading powermock to latest, 1.6.4).

    The 188 Saros/E unit tests work fine with powermock 1.6.4. @Franz, @Stefan So what is easier? Adding JUnit 4.11 as library to core/test/lib or upgrading powermock to 1.6.4?

     
    • Franz Zieris

      Franz Zieris - 2015-12-19

      For now, I'd favor upgrading powermock.

       
  • Stefan Rossbach

    Stefan Rossbach - 2015-12-20

    All those testing libraries and other stuff should be put into a dedicated project instead of moving them to the core project. Doing it this way you can use different versions for different projects.

     
  • Holger Schmeisky

    Yup, then we also don't have the same library in the same version 3 times. For this one I'd like to upgrade the powermock-easymock in the 3 projects to fix this issue.

    Another solution would be to move the dependencies to Ivy, keeping the ant files for the build itself:

    https://github.com/saros-project/saros/blob/master/de.fu_berlin.inf.dpp.server/ivy.xml

     

    Last edit: Holger Schmeisky 2015-12-22
  • Franz Zieris

    Franz Zieris - 2016-09-23
    • Labels: IntelliJ --> IntelliJ, Intellij
     
  • Franz Zieris

    Franz Zieris - 2016-09-23
    • labels: IntelliJ, Intellij --> Intellij
     
  • tobous

    tobous - 2018-03-20
    • status: open --> pending-fixed
     
  • tobous

    tobous - 2018-03-20

    Fixed in commit f21046496b112ac1adedddd4da379f7db7fd3488. Now uses jUnit 4.11 already present for the Saros Core. See commit message for other changes.

     
  • tobous

    tobous - 2018-03-22
    • Labels: Intellij --> Intellij, IntelliJ
     
  • tobous

    tobous - 2018-03-22
    • labels: Intellij, IntelliJ --> IntelliJ
     
  • tobous

    tobous - 2019-12-02
    • Status: pending-fixed --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB