#26 Doom Legacy not setting skill correctly on multiplayer games

[Leonardo Montenegro]

Upon creating a multiplayer game by going to "New game -> Multiplayer -> Start Server", whenever skill level I choose, it isn't setted correctly. Instead, it forces to skill 2, "Hurt Me Plenty", not allowing me to create a deathmatch on a higher skill, thus influentiating on which weapons and items will be shown on the level.

This is happening because, on "m_menu.c" file, inside "M_StartServer" function, there's this line which is responsible for setting some of the parameters of the multiplayer game being created:

COM_BufAddText(va("stopdemo;splitscreen %d;deathmatch %d;map \"%s\" -monsters %d skill %d\n", 
                      StartSplitScreenGame, cv_newdeathmatch.value, 
                      (gamemode==doom2_commercial)? cv_nextmap.string : cv_nextepmap.string,
                      cv_monsters.value, cv_skill.value));

It's missing a hyphen in the "skill" parameter. Just add it back, and it will work as it should again:

COM_BufAddText(va("stopdemo;splitscreen %d;deathmatch %d;map \"%s\" -monsters %d -skill %d\n", 
                      StartSplitScreenGame, cv_newdeathmatch.value, 
                      (gamemode==doom2_commercial)? cv_nextmap.string : cv_nextepmap.string,
                      cv_monsters.value, cv_skill.value));

[Wesley Johnson]

Good catch. I never get to play deathmatch so I rely upon the people who use those features to catch things like this. I will fix that immediately.

I very much would like to replace all those COM_BufAddText to just call some functions directly, but am afraid of what it might break. But some day I will likely try to do that.

[Wesley Johnson]

This is actually a bug. I would move it to the bug reports, if I actually could figure how to do that in this system.

Support requests are usually of the kind "Help, I don't know how to ..."

Patch has been made, will be in next commit batch.
Thank you.