From: Adam T. <aa-...@us...> - 2022-05-26 01:24:19
|
> Also, if `__name__ == '__main__'` is problematic in a file called `__main__.py`. In a script, import `docutils.__main__` will work differently from `from docutils import __main__`. This isn't true to my knowledge -- `docutils/__main__.py` has `__name__ == "docutils.__main__`. So the `__name__ == '__main__'` block never gets triggered in either case of programmatic imports. > This would also have the advantage ... will not import argparse. Importing argparse takes around 22ms on my computer, I'd argue it is not worth complicating `docutils.core` by adding these functions to it for a 22ms benefit. ```sh PS C:\Users\Adam> python -X importtime -c "import argparse" import time: self [us] | cumulative | imported package [snip] import time: 22034 | 230461 | argparse ``` > I'd wait with rst2… entry points until we decided which ones to keep. Good point. A --- ** [patches:#186] Modernise packaging** **Status:** open **Group:** None **Created:** Fri Dec 31, 2021 03:16 AM UTC by Adam Turner **Last Updated:** Fri May 20, 2022 05:45 PM UTC **Owner:** nobody **Attachments:** - [0001-Use-flit-and-pyproject.toml.patch](https://sourceforge.net/p/docutils/patches/186/attachment/0001-Use-flit-and-pyproject.toml.patch) (12.2 kB; application/octet-stream) - [0002-Use-entry-points.patch](https://sourceforge.net/p/docutils/patches/186/attachment/0002-Use-entry-points.patch) (20.7 kB; application/octet-stream) - [0003-update-docs-etc-after-packaging-changes.patch](https://sourceforge.net/p/docutils/patches/186/attachment/0003-update-docs-etc-after-packaging-changes.patch) (49.3 kB; application/octet-stream) Hi, I had a go at modernising the packaging stack. `setup.py` based invocations have been deprecated (https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html), and setuptools may remove them in the future. This takes the opportunity to move to a PEP 621 based declarative config, and also fixes a longstanding TODO item about providing script wappers for the frontend tools on windows, by migrating them to entry points. I've updated install and development docs with the new guidance, and updated references to the frontend tools to remove `.py`, given they are now installed as proper scripts. Hope this is appreciated -- happy to make revisions etc to help getting this merged. A --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |