[Docutils-develop] [docutils:bugs] Re: #441 Move from "optparse" to "argparse".

[Adam T. <aa-...@us...>]

High level review:

- The header states the GPL licence rather than public domain -- would you be happy to say public domain instead? It would be really bad to add GPL code into the core of Docutils, which is currently public domain / BSD. 
- Strong negative on validation within ConfigParser. I think we should make validation distinct from parsing, but that should be a different change
- I think the "ACTIVE" section could be a method or an `@property` -- `ConfigParser.active_config` or suchlike, that would be accessed by `OptionParser`.
- Explicit side effect handling -- this is fine but we should document that only "XXX" is allowed to have side effects for backwards compatability purposes, and ideally we would deprecate the idea of side effects.
- apart from that it seems reasonable at a high level, let me know if you want a review of the specific implementation (there's a few things I'd change but I don't want to derail the discussion)

A


---

** [bugs:#441] Move from "optparse" to "argparse".**

**Status:** open
**Created:** Thu Jan 06, 2022 03:02 PM UTC by Günter Milde
**Last Updated:** Sat Feb 05, 2022 01:47 AM UTC
**Owner:** Günter Milde


The optparse documentation says:
> Deprecated since version 3.2: The optparse module is deprecated and will not be developed further; development will continue with the argparse module.

We are currently suppressing related deprecation warnings in the test suite.
After raising the Python dependency to >=3.7, now may be the right time to make the move.


---

Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.