[Docutils-develop] [docutils:patches] Re: #192 Codebase modernisation

[Günter M. <mi...@us...>]

On 2022-01-26, Adam Turner wrote:

> I noticed you removed some extra `u` characters and some
> combining marks compared to my original patch.
> Patch to fix (along with some other things)

Thank you for the fixup.

> The some other things are some str.join generator expression changes,

Here, I did also some refactoring to avoid hard to read 
"parenthesis clusters" like
~~~
...
+  % (self.name, ' < '.join((path, *(pth for pth, opt
+                           in reversed(include_log))))))
~~~

> removing one more set of parens

In the context of keyword arguments, I prefer the parentheses over a
space because of operator precedence
cf https://www.python.org/dev/peps/pep-0008/#other-recommendations

Thanks again.


---

** [patches:#192] Codebase modernisation**

**Status:** open
**Group:** None
**Created:** Wed Jan 26, 2022 12:37 AM UTC by Adam  Turner
**Last Updated:** Wed Jan 26, 2022 11:35 PM UTC
**Owner:** nobody


This follows on from the Python 2.x cleanup work.

The total diff looks quite large, but the marjority of these are mechanical search / replace changes -- viewing by commit or in groups of commits may be best. 

https://github.com/AA-Turner/docutils/pull/12 // https://github.com/AA-Turner/docutils/pull/12.patch

I kept things seperate so that it would be easier to extract and rebase changes that you don't want to merge (hopefully there aren't any of these!).

A


---

Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.