[Docutils-develop] [docutils:patches] #192 Codebase modernisation

[Adam T. <aa-...@us...>]

Thanks! I really appreciate it.

> error catching: here we should check for the most appropriate (sub)class to use,

OK. Python 3 did change IO and Environment errors to be identical to OSError -- but as you say the exception hierarchy was reworked so e.g. FileNotFoundError or whatever may be more appropriate.

> the recommonmark test 

As currently it is just a no-op statement. (I don't have recommonmark set up for docutils on my laptop, which is probably why I missed that tests fail -- sorry!) Perhaps just remove?

>  some set/dict literals where the "tratidional" form seems more clear,

OK. For html4css1 Line 159, perhaps `special_characters = _html_base.HTMLTranslator.special_characters.copy()` if you don't like the `{**...}` form? It makes that the intention is to copy much clearer.

A



---

** [patches:#192] Codebase modernisation**

**Status:** open
**Group:** None
**Created:** Wed Jan 26, 2022 12:37 AM UTC by Adam  Turner
**Last Updated:** Wed Jan 26, 2022 10:35 PM UTC
**Owner:** nobody


This follows on from the Python 2.x cleanup work.

The total diff looks quite large, but the marjority of these are mechanical search / replace changes -- viewing by commit or in groups of commits may be best. 

https://github.com/AA-Turner/docutils/pull/12 // https://github.com/AA-Turner/docutils/pull/12.patch

I kept things seperate so that it would be easier to extract and rebase changes that you don't want to merge (hopefully there aren't any of these!).

A


---

Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.