Re: [Docutils-develop] [docutils:patches] Re: #191 Update URLs

[Guenter M. <mi...@us...>]

On 2022-01-21, Adam Turner wrote:

> Sorry if it caused a headache. It was really a search + replace http://
> to https:// 

However, this needs to be followed by a check of the resulting URL
(some work fine with htpp but not https (because of non-standard
certificates) or, as sourceforge, because they changed the domain for some
https services.
>From the patch and its meta-data I did not find out whether (and to what
extend) you did this checks. So I decided to double-check.

> but I didn't want to do a commit per domain or etc. as it
> would have been many many small commits. 

Fair enough. Still, separating the changes in documentation and code seemed a
good idea to me.

> Didn't realise the MathML point -- all tests passed, but if I changed
> the URL in the test then it is sort of a no-op. 

Changing code and tests in one search + replace operation is dangerous,
because this can lead to both beeing faulty. I made it a habit to only
change the tests after looking at the difference.

Before moving changed documents from "functional/output" to 
"functional/expected", changes also need an additional check:

- convert *.tex documents with `pdflatex` or `xelatex`/`lualatex`
  and inspected the PDF for problems.
- check *.xml documents with `xmllint --valid`
- inspect *.html documents in a browser (or several different browsers)
  and check the validity (the standalone_*html documents have a button in
  the footer for this).