From: Adam T. <aa-...@us...> - 2022-01-20 12:09:39
|
> Changing the IDN breaks the validity of generated XML documents: I thought it was a bit of a riskier change! > Commit 6/6 did not apply cleanly here Yeah, commit 6 won't apply if you don't apply #5 -- I kept them apart but should have thought about that, sorry. See https://github.com/AA-Turner/docutils/pull/11 // https://github.com/AA-Turner/docutils/pull/11.patch for the "clean" commit #6 > Maybe this is also why flake8 failed? // flagged "Some checks were not successful" Flake8 fails on master with the following errors -- it wasn't anything I introduced ``` docutils/frontend.py:389:47: F821 undefined name 'locale_encoding' docutils/utils/math/latex2mathml.py:861:1: C901 'handle_cmd' is too complex (68) docutils/utils/math/latex2mathml.py:1210:52: E712 comparison to True should be 'if cond is True:' or 'if cond:' docutils/utils/math/latex2mathml.py:1221:52: E712 comparison to True should be 'if cond is True:' or 'if cond:' docutils/utils/math/math2html.py:2350:18: F821 undefined name 'Label' docutils/utils/math/math2html.py:2353:5: F821 undefined name 'Label' ``` A --- ** [patches:#191] Update URLs ** **Status:** open **Group:** None **Created:** Thu Jan 20, 2022 04:40 AM UTC by Adam Turner **Last Updated:** Thu Jan 20, 2022 09:57 AM UTC **Owner:** nobody Documentation / minor change. There are a lot of old URLs in the repo -- e.g. `docutils.sf.net`, `docutils.sourceforge.net` -- whilst these currently still work, we should update them all to the canonical `https://docutils.sourceforge.io` This patch does that, and also generally updates several other links to `https://` -- I tested each domain, so didn't update some old sourceforge domains that don't support `https://`. I also updated the `docutils.dtd` IDN in a single commit, so it can be dropped if wanted. I'd certainly reccomend applying the first 4 commits, and ideally the entire patch. https://github.com/AA-Turner/docutils/pull/10 // https://github.com/AA-Turner/docutils/pull/10.patch A --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |