Re: [Docutils-develop] Issue #169 Hyperlink extension rewriting

[John L. C. <jl...@po...>]

Günter,

Thanks very much for the useful feedback.

On Sat, Aug 22, 2020 at 4:37 PM Guenter Milde via Docutils-develop
<doc...@li...> wrote:
> I like the general idea but would rename "update_filename_extension()" to
> "map_filename_extension()".

Yes, that does sound like a better name.

> The test framework allows overwriting config settings, so it should be
> possible to test with different settings.
> A unit test is more lightwight, runs faster as a functional test
> and should suffice.
>
> The change to buildhtml is unrelated, should not be bundled here and
> discussed separately.

That's a good point; I feel a bit embarrassed for including that
functionality in the previous patch.  I have posted a new patch that
takes your suggestions into account, including the rename of the
method, switching to using unit testing, and leaving out the change to
buildhtml.py.  I posted the updated patch on the patch tracker:
<https://sourceforge.net/p/docutils/patches/169/#acab>.

Peace,

    John L. Clark