From: Matěj C. <mc...@ce...> - 2019-02-08 01:04:42
|
On 2019-02-07, 20:04 GMT, Dave Kuhlman wrote: > Question for the docutils list: When I apply the `flake8` > style and error checker to `__init__.py`, I get lots of > warnings (405 when I count them with `wc`). Most of them have > to do with indentation, missing or extra blank lines, missing > or extra spaces, etc. I'm willing to clean those up. Or, > would that amount of changes be too disruptive (for example, > in making svn history less useful)? Anyone have an opinion? > Clean it up? Leave it alone? If I do it, I'll make an extra > check-in with only those cleanup changes. I have no authority to speak for anybody, but my comment would be: +1 but do it in one commit named "PEP8ization" or something like that, which should in effect have no change to the functionality. Don't mix it with the real changes like fixing bugs. Matěj -- https://matej.ceplovi.cz/blog/, Jabber: mc...@ce... GPG Finger: 3C76 A027 CA45 AD70 98B5 BC1D 7920 5802 880B C9D8 Give a man a regular expression and he’ll match a string… teach him to make his own regular expressions and you’ve got a man with problems. -- yakugo in http://regex.info/blog/2006-09-15/247#comment-3022 |