From: Guenter M. <mi...@us...> - 2017-05-16 12:10:26
|
On 2017-05-16, Matej Cepl wrote: > On 16/05/17 01:42, Dave Kuhlman wrote: >> 1. Images that use ":width: xx%" are scaled to the line width. ... >> 2. The header/title of an admonition (for example, a note) now >> follows the style of the admonition header ... >> 3. The unit test error that you found is fixed. ... Wonderfull. Thanks a lot for taking care of this. >> Please let me know if we are getting closer, what else needs fixing, >> etc. > This works for me. As far as me I would get this let be released. I second this, please commit and then it may be really time for 0.14! I have one remaining question: I understand, that LO/OO expects both, language and region tag of a document to be set. I also understand that auto-filling the region tag is tricky. What happens exactly, if in an rst2odt-exported document the language tag is set but the region tag is missing: a) an error/warning b) the region is set to "US" c) the region is set according to the users locale? What should Docutils do in these cases? >> By default, it was passing in "en" as the language, whereas now it >> needs to be "en-US" or to be omitted. I overrode it with "en-US". Ther problem here is, that according to our specs, the default for "language-code" is Default: English ("en"). Options: ``--language, -l``. Unless absolutely required otherwise, I suggest passing just "en". If this is not possible, the odt writer could use a different default (this needs to be documented). Rationale: not only Mexican and Castillean Spaniards disagree about the default region tag for a language, narrowing "en" to American English must at least be documented. But this may also be sorted out later. Thanks again, Günter |