[Docutils-users] Import bug in docutils/parsers/rst/state.py

[Larry H. <la...@ha...>]

The current version of docutils/parsers/rst/state.py has this code:

    try:
         import roman
    except ImportError:
         import docutils.utils.roman as roman

Since there is no "roman.py" in "docutils/parsers/rst", I'm not sure 
when that bare "import roman" is a good idea.  It actually seems to me 
like a bad idea, because if you have a "roman.py" in the current 
directory, it'll find that instead.  (And, if that happens to be a 
Python 2 file, while you're running Python 3, you get a SyntaxError.)  
Alternatively, if 'roman' in sys.modules, "import roman" will grab 
that... whatever it is.

Surely it would be best to drop the first three lines of this snippet, 
and always explicitly import docutils.utils.roman as roman.  After all, 
explicit is better than implicit.


//arry/

p.s. I'm not subscribed to this list.