Re: [Docutils-users] docutils sometimes contains roman

[David G. <go...@py...>]

On Fri, Apr 9, 2010 at 08:52, David Goodger <go...@py...> wrote:
> On Fri, Apr 9, 2010 at 00:26, Craig McQueen <ce...@mc...> wrote:
>> I downloaded a snapshot yesterday, and tried to install it with
>>
>>    python setup.py install
>>
>> I get a traceback:
>>
>> File "...\setup.py", line 93, in do_setup
>>    kwargs['py_modules'] += extras
>> KeyError: 'py_modules'
>>
>> I'm guessing this is a problem related to recent work to handle the 'roman'
>> dependency. It simply doesn't work if the 'roman' module isn't already installed.
>>
>> Am I right, or am I missing something?
>
> Thanks for the bug report!
>
> It actually seems to stem directly from r6267 (by Günter Milde), when
> package_data['py_modules'] was removed. This revision was related to
> the developer tools (buildhtml.py & quicktest.py) and Python 3
> conversion. The roman.py issue you reported seems to be a side-effect.

Also r6262, where this change was made to setup.py:

-        kwargs['py_modules'] = extras
+        kwargs['py_modules'] += extras

It probably should have been reverted in r6267.

> Günter, could you fix this?

-- 
David Goodger <http://python.net/~goodger>