docutils-develop

[Docutils-develop] Issue #169 Hyperlink extension rewriting

[John L. C. <jl...@po...>]

A week ago I posted a new issue to the patch tracker:
<https://sourceforge.net/p/docutils/patches/169/>.  I wanted to bring
it to the attention of this mailing list, because the automated email
that the tracker sends to this list was put in a moderation queue.  I
don't know what the status of that moderation is.  I noted after I
posted the patch that I didn't remove a debugging line; I'm happy to
submit an updated or additional patch as desired, but even more than
that I am eager to discuss the change.

Peace,

    John L. Clark

Re: [Docutils-develop] Issue #169 Hyperlink extension rewriting

[Guenter M. <mi...@us...>]

Dear John,

thank you for the patch proposal.

On 2020-08-19, John L. Clark wrote:
> A week ago I posted a new issue to the patch tracker:
><https://sourceforge.net/p/docutils/patches/169/>.  I wanted to bring
> it to the attention of this mailing list, because the automated email
> that the tracker sends to this list was put in a moderation queue.  I
> don't know what the status of that moderation is.  I noted after I
> posted the patch that I didn't remove a debugging line; I'm happy to
> submit an updated or additional patch as desired, but even more than
> that I am eager to discuss the change.

Some first thoughts after a glance at the patch:

I like the general idea but would rename "update_filename_extension()" to
"map_filename_extension()".

The setting should also work for other writers (LaTeX, ODT, at least). 

The test framework allows overwriting config settings, so it should be
possible to test with different settings.
A unit test is more lightwight, runs faster as a functional test
and should suffice.

The change to buildhtml is unrelated, should not be bundled here and
discussed separately.


Thanks,

Günter

Re: [Docutils-develop] Issue #169 Hyperlink extension rewriting

[John L. C. <jl...@po...>]

Günter,

Thanks very much for the useful feedback.

On Sat, Aug 22, 2020 at 4:37 PM Guenter Milde via Docutils-develop
<doc...@li...> wrote:
> I like the general idea but would rename "update_filename_extension()" to
> "map_filename_extension()".

Yes, that does sound like a better name.

> The test framework allows overwriting config settings, so it should be
> possible to test with different settings.
> A unit test is more lightwight, runs faster as a functional test
> and should suffice.
>
> The change to buildhtml is unrelated, should not be bundled here and
> discussed separately.

That's a good point; I feel a bit embarrassed for including that
functionality in the previous patch.  I have posted a new patch that
takes your suggestions into account, including the rename of the
method, switching to using unit testing, and leaving out the change to
buildhtml.py.  I posted the updated patch on the patch tracker:
<https://sourceforge.net/p/docutils/patches/169/#acab>.

Peace,

    John L. Clark