go...@us... wrote: > added "title" directive > > Modified: trunk/docutils/docutils/parsers/rst/directives/misc.py > =================================================================== > > +def title(name, arguments, options, content, lineno, > + content_offset, block_text, state, state_machine): > + state_machine.document.settings.title = arguments[0] settings.title is the wrong place, IMO. The title should be part of the document tree itself. Maybe a "title" attribute of the "document" node? We could also set that attribute from the doctitle transform then, so that writers need no title-choosing logic (settings.title overrides document title node). That would be better because it simplifies writing writers a bit. -- For private mail please ensure that the header contains 'Felix Wiemann'. "the number of contributors [...] is strongly and inversely correlated with the number of hoops each project makes a contributing user go through." -- ESR |
From: David G. <go...@py...> - 2005-06-16 02:26:02
Attachments:
signature.asc
|
[Felix Wiemann] > settings.title is the wrong place, IMO. The title should be part of > the document tree itself. Maybe a "title" attribute of the > "document" node? That's feasible. But should there be a command-line option / config-file setting at all? I think it's useful. If so, there's going to be a settings.title anyway. > We could also set that attribute from the doctitle transform then, > so that writers need no title-choosing logic (settings.title > overrides document title node). That would be better because it > simplifies writing writers a bit. I don't follow. Please understand, this directive/setting only deals with the *metadata* document title (HTML's <head><title>), not the rendered document title (HTML's <h1 class="title">). -- David Goodger <http://python.net/~goodger> |
From: David G. <go...@py...> - 2005-06-29 19:22:14
Attachments:
signature.asc
|
[Felix Wiemann] > I just added the title metadata determining code to the DocTitle > transform. This has the big advantage that the writer has been > simplified a lot (see "svn diff -r 3620:3621 writers/html4css1.py"). Looks good! > Simple writers are a Good Thing. Yes :-) -- David Goodger <http://python.net/~goodger> |
From: Felix W. <Fel...@gm...> - 2005-06-29 12:11:52
|
David Goodger wrote: > Felix Wiemann wrote: > >> The title should be part of the document tree itself. Maybe a >> "title" attribute of the "document" node? > > That's feasible. > > But should there be a command-line option / config-file setting at > all? I think it's useful. If so, there's going to be a > settings.title anyway. Yes, but that's no problem, IMO. I just added the title metadata determining code to the DocTitle transform. This has the big advantage that the writer has been simplified a lot (see "svn diff -r 3620:3621 writers/html4css1.py"). Simple writers are a Good Thing. -- For private mail please ensure that the header contains 'Felix Wiemann'. "the number of contributors [...] is strongly and inversely correlated with the number of hoops each project makes a contributing user go through." -- ESR |