From: Adam T. <aa-...@us...> - 2022-01-05 20:30:19
|
--- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Wed Jan 05, 2022 08:30 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Günter M. <mi...@us...> - 2022-01-06 13:52:02
|
On 2022-01-05, Adam Turner via Docutils-develop wrote in gmane.text.docutils.devel: > The first commit removes textual references, the remaining do some > clean-up in `nodes` and `error_reporting` -- I don't know if these are > helpful. I think at least the first commit should be applied, though. I prepared a commit based on patch 1 with some differences: * Don't touch nodes.py (do all changes in this file in one commit). * Don't touch error_reporting.py (my plan is to first remove all uses in Docutils and then deprecate the module with a DeprecationWarning so no update needed inside). * Don't touch punctuation_chars.py (it's a generated file!). * Some additional formatting. Do you want to have a look or may I just push? > https://github.com/AA-Turner/docutils/pull/4 > https://github.com/AA-Turner/docutils/pull/4.patch (If Github would provide a "commitdiff" link similar to https://repo.or.cz/w/docutils.git, you could just link to the commit or tree with the patches without need for a pull request :) Thank you for your work. --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Wed Jan 05, 2022 08:30 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Adam T. <aa-...@us...> - 2022-01-06 13:55:31
|
> If Github would provide a "commitdiff" link Do you mean something like https://github.com/AA-Turner/docutils/compare/master...AA-Turner:remove-lingering-py2 // https://github.com/AA-Turner/docutils/compare/master...AA-Turner:remove-lingering-py2.patch ? The pull request interface is useful for inline reviews and text, although of course Docutils uses SF so its of less use --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Wed Jan 05, 2022 08:30 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Günter M. <mi...@us...> - 2022-01-06 14:49:40
|
> Do you mean something like https://github.com/AA-Turner/docutils/compare/master...AA-Turner:remove-lingering-py2 Kind of. If only I could find a link/button to the raw patch on this page. Having to add ".patch" in the URL-field of my browser is possible but no good UI. --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Thu Jan 06, 2022 01:57 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Adam T. <aa-...@us...> - 2022-01-06 13:57:13
|
Oops sorry didn't mean to send that yet! > Do you want to have a look or may I just push? I trust your judgement :P -- if there's anything I spot later on I can prepare a new patch. A --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Thu Jan 06, 2022 01:55 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Günter M. <mi...@us...> - 2022-01-14 16:36:13
|
@aa-turner Could you have a look whether I have missed something important? If there are no leftovers, we could close this one. Thanks again for the patch. --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Thu Jan 06, 2022 02:49 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Adam T. <aa-...@us...> - 2022-01-15 03:58:48
|
There are a few references in `sandbox/infrastructure` -- I don't know which of these files are used. The only other places I'd look is where `Py3k` is referenced -- e.g. `test_io`, `parsers.rst.directives.(tables|misc)`. This is more just to check the text is still accurate & relevant. A --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Fri Jan 14, 2022 04:36 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Günter M. <mi...@us...> - 2022-01-15 18:23:41
|
On 2022-01-15, Adam Turner wrote: > There are a few references in `sandbox/infrastructure` -- I don't know > which of these files are used. The sandbox is a place for 3rd-party content under responsibility of the respective authors. > The only other places I'd look is where `Py3k` is referenced -- e.g. > `test_io`, `parsers.rst.directives.(tables|misc)`. This is more just to > check the text is still accurate & relevant. The "io" module may eventually go the way of error_messages, as its main task (de/encoding from Unicode to the specified encodings) is now provided "transparently" by the standard lib. But we have to think about additional capabilities (like encoding guessing) and backwards compatibility, so this is a complex tast that merits its own ticket and time-frame. I did find one minor issue: the messages for failed tests contain `b'...'`, a sign that somewhere in our test framework bytes are used instead of strings. (I suppose because the "diff" module did not work with Unicode.) Thanks. --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Sat Jan 15, 2022 03:58 AM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Adam T. <aa-...@us...> - 2022-01-15 20:49:26
|
Sounds like this issue can be closed then -- `docutils.io` as you say will be its own issue. A --- ** [patches:#188] Remove lingering references to Python 2** **Status:** open **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Sat Jan 15, 2022 03:58 AM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |
From: Günter M. <mi...@us...> - 2022-01-18 16:15:30
|
- **status**: open --> closed-fixed --- ** [patches:#188] Remove lingering references to Python 2** **Status:** closed-fixed **Group:** None **Created:** Wed Jan 05, 2022 08:30 PM UTC by Adam Turner **Last Updated:** Sat Jan 15, 2022 08:49 PM UTC **Owner:** nobody @milde The first commit removes textual references, the remaining do some clean-up in `nodes` and `error_reporting` -- I don't know if these are helpful. I think at least the first commit should be applied, though. https://github.com/AA-Turner/docutils/pull/4 // https://github.com/AA-Turner/docutils/pull/4.patch --- Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options. Or, if this is a mailing list, you can unsubscribe from the mailing list. |